This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Add bootstrap API spec #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@diasdavid When the spec is merged, I'll start writing the tests! |
|
@richardschneider you can use the tests from https://github.com/ipfs/js-ipfs-api/blob/master/test/bootstrap.spec.js just by importing them here. It would be good to merge the spec with the tests and ensure that both js-ipfs and js-ipfs-api follow it so that we don't confuse users. |
|
Sounds like a good plan. Will do tomorrow. |
|
@diasdavid As requested, I've added the tests. |
This was referenced Feb 15, 2018
daviddias
approved these changes
Feb 15, 2018
daviddias
force-pushed
the
bootstrap-spec
branch
from
48ca76b to
c769f0d
Compare
daviddias
approved these changes
Feb 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the spec as implemented by
js-ipfs. See #97